This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-1361. Fix Submarine SQL injection vulnerability #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1037 +/- ##
=======================================
Coverage 75.98% 75.98%
=======================================
Files 119 119
Lines 5000 5000
=======================================
Hits 3799 3799
Misses 1201 1201
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cdmikechen
added a commit
to shangyuantech/submarine
that referenced
this pull request
Feb 5, 2023
### What is this PR for?
Currently a SQL injection vulnerability has been checked in submarine and the relevant part of the `like` statement in mybatis needs to be fixed.
### What type of PR is it?
Bug Fix
### Todos
* [x] - replace `like` statement to `concat('%', #{param}, '%')`
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1361
### How should this be tested?
Added a test case verification code in `submarine-server/server-database/src/test/java/org/apache/submarine/server/database/workbench/database/service/SysUserServiceTest.java`
### Screenshots (if appropriate)
NA
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
Author: cdmikechen <cdmikechen@apache.org>
Signed-off-by: cdmikechen <cdmikechen@apache.org>
Closes apache#1037 from cdmikechen/SUBMARINE-1361 and squashes the following commits:
34fb34b [cdmikechen] Avoid sql injection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Currently a SQL injection vulnerability has been checked in submarine and the relevant part of the
likestatement in mybatis needs to be fixed.What type of PR is it?
Bug Fix
Todos
likestatement toconcat('%', #{param}, '%')What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1361
How should this be tested?
Added a test case verification code in
submarine-server/server-database/src/test/java/org/apache/submarine/server/database/workbench/database/service/SysUserServiceTest.javaScreenshots (if appropriate)
NA
Questions: